Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #332, Apply latest contributor license agreement links #331

Merged
merged 1 commit into from
Apr 19, 2022

Conversation

chillfig
Copy link
Contributor

@chillfig chillfig commented Mar 31, 2022

Describe the contribution

Adds checklist for CLA and contributing guide.

Expected behavior changes
Working links

Additional context
Depends on nasa/cFS#448

Contributor Info - All information REQUIRED for consideration of pull request
Justin Figueroa, ASRC Federal

@skliper
Copy link
Contributor

skliper commented Apr 4, 2022

Recommend opening issues in all the affected repos (including PSP), link this PR, and update the commit message to match the recommended format.

@chillfig chillfig changed the title Changes links to cla Fix #332, Apply latest contributor license agreement links Apr 4, 2022
@chillfig chillfig self-assigned this Apr 5, 2022
@chillfig chillfig added the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Apr 6, 2022
@astrogeco
Copy link
Contributor

CCB:2022-04-06 APROVED with CHANGES

  • Replace explicit link to CLA files with link to CLA section in cFS/Contributing.md

@astrogeco astrogeco added CCB:Approved Indicates Approval by CCB and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Apr 6, 2022
@chillfig chillfig force-pushed the update_cla_links branch 3 times, most recently from ed113cd to 4a6ce54 Compare April 6, 2022 20:21
- **HAND SIGNED** Company CLA must be on file (once per release): [Company CLA](https://github.com/nasa/cFE/blob/master/docs/GSC_18128_Corp_CLA_form_1219.pdf)
- Else if Individual
- **HAND SIGNED** Individual CLA must be on file (once per release): [Individual CLA](https://github.com/nasa/cFE/blob/master/docs/GSC_18128_Ind_CLA_form_1219.pdf)
- Note CLA's apply to software contributions.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no apostrophe ', should add the word "only" before software contributions

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@astrogeco - note that when I tried using the link to the subsection in the cFS contributing guide it didn't go to the appropriate section. Probably want to confirm this actually works...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.github/pull_request_template.md Outdated Show resolved Hide resolved
Replaces explicit link to CLA files with link to CLA section in cFS/Contributing.md
Adds checklist for CLA and contributing guide, removes extra spacing, changes grammar
astrogeco added a commit to nasa/cFS that referenced this pull request Apr 18, 2022
@astrogeco astrogeco merged commit 55208b8 into nasa:main Apr 19, 2022
@chillfig chillfig deleted the update_cla_links branch April 19, 2022 13:29
astrogeco added a commit to nasa/cFS that referenced this pull request Apr 19, 2022
astrogeco added a commit to nasa/cFS that referenced this pull request Apr 19, 2022
**Combines**

nasa/cFE#2091 v7.0.0-rc4+dev110

**Includes**

*cFE*

nasa/cFE#2077, Remove contributor license agreement

nasa/cFE#2085, Use reusable documentation generation workflow

nasa/cFE#2080, Add config module to coverage enforcemnt

nasa/cFE#2081, Improve ES unit test coverage

nasa/cFE#2082, Only increment SB InternalErrorCounter on errors

*osal*

nasa/osal#1246, Apply latest contributor license agreement links

*PSP*

nasa/PSP#331, Apply latest contributor license agreement links

nasa/PSP#334, Fix input to static analysis workflow

Co-authored-by: Jacob Hageman    <skliper@users.noreply.github.com>
Co-authored-by: Justing Figueroa <chillfigskliper@users.noreply.github.com>
astrogeco added a commit to nasa/cFS that referenced this pull request Apr 19, 2022
**Combines**

nasa/cFE#2091 v7.0.0-rc4+dev110

**Includes**

*cFE*

nasa/cFE#2077, Remove contributor license agreement

nasa/cFE#2085, Use reusable documentation generation workflow

nasa/cFE#2080, Add config module to coverage enforcemnt

nasa/cFE#2081, Improve ES unit test coverage

nasa/cFE#2082, Only increment SB InternalErrorCounter on errors

*osal*

nasa/osal#1246, Apply latest contributor license agreement links

*PSP*

nasa/PSP#331, Apply latest contributor license agreement links

nasa/PSP#334, Fix input to static analysis workflow

Co-authored-by: Jacob Hageman    <skliper@users.noreply.github.com>
Co-authored-by: Justing Figueroa <chillfig@users.noreply.github.com>
@dmknutsen dmknutsen added this to the Draco milestone Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apply latest contributor license agreement links
4 participants