Fix #332, Apply latest contributor license agreement links #331
+6
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Recommend opening issues in all the affected repos (including PSP), link this PR, and update the commit message to match the recommended format. |
chillfig
changed the title
chillfig
added
the
CCB:Ready
|
CCB:2022-04-06 APROVED with CHANGES
|
astrogeco
added
CCB:Approved
chillfig
force-pushed
the
update_cla_links
branch
3 times, most recently
from
ed113cd
to
4a6ce54
Compare
astrogeco
reviewed
Apr 6, 2022
.github/pull_request_template.md
Outdated
| - **HAND SIGNED** Company CLA must be on file (once per release): [Company CLA](https://github.com/nasa/cFE/blob/master/docs/GSC_18128_Corp_CLA_form_1219.pdf) | ||
| - Else if Individual | ||
| - **HAND SIGNED** Individual CLA must be on file (once per release): [Individual CLA](https://github.com/nasa/cFE/blob/master/docs/GSC_18128_Ind_CLA_form_1219.pdf) | ||
| - Note CLA's apply to software contributions. |
There was a problem hiding this comment.
no apostrophe ', should add the word "only" before software contributions
There was a problem hiding this comment.
@astrogeco - note that when I tried using the link to the subsection in the cFS contributing guide it didn't go to the appropriate section. Probably want to confirm this actually works...
There was a problem hiding this comment.
It won't work until nasa/cFS#448 is merged. It does work on the fork https://github.com/chillfig/cFS/blob/add_cla/CONTRIBUTING.md#contributor-license-agreement-cla
astrogeco
suggested changes
Apr 6, 2022
Replaces explicit link to CLA files with link to CLA section in cFS/Contributing.md Adds checklist for CLA and contributing guide, removes extra spacing, changes grammar
chillfig
force-pushed
the
update_cla_links
branch
from
4a6ce54
to
c36dd93
Compare
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Apr 18, 2022
nasa/PSP#334, Fix input to static analysis workflow
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Apr 19, 2022
nasa/PSP#334, Fix input to static analysis workflow
2 tasks
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Apr 19, 2022
**Combines** nasa/cFE#2091 v7.0.0-rc4+dev110 **Includes** *cFE* nasa/cFE#2077, Remove contributor license agreement nasa/cFE#2085, Use reusable documentation generation workflow nasa/cFE#2080, Add config module to coverage enforcemnt nasa/cFE#2081, Improve ES unit test coverage nasa/cFE#2082, Only increment SB InternalErrorCounter on errors *osal* nasa/osal#1246, Apply latest contributor license agreement links *PSP* nasa/PSP#331, Apply latest contributor license agreement links nasa/PSP#334, Fix input to static analysis workflow Co-authored-by: Jacob Hageman <skliper@users.noreply.github.com> Co-authored-by: Justing Figueroa <chillfigskliper@users.noreply.github.com>
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Apr 19, 2022
**Combines** nasa/cFE#2091 v7.0.0-rc4+dev110 **Includes** *cFE* nasa/cFE#2077, Remove contributor license agreement nasa/cFE#2085, Use reusable documentation generation workflow nasa/cFE#2080, Add config module to coverage enforcemnt nasa/cFE#2081, Improve ES unit test coverage nasa/cFE#2082, Only increment SB InternalErrorCounter on errors *osal* nasa/osal#1246, Apply latest contributor license agreement links *PSP* nasa/PSP#331, Apply latest contributor license agreement links nasa/PSP#334, Fix input to static analysis workflow Co-authored-by: Jacob Hageman <skliper@users.noreply.github.com> Co-authored-by: Justing Figueroa <chillfig@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Adds checklist for CLA and contributing guide.
Expected behavior changes
Working links
Additional context
Depends on nasa/cFS#448
Contributor Info - All information REQUIRED for consideration of pull request
Justin Figueroa, ASRC Federal