-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #332, Apply latest contributor license agreement links #331
Conversation
Recommend opening issues in all the affected repos (including PSP), link this PR, and update the commit message to match the recommended format. |
CCB:2022-04-06 APROVED with CHANGES
|
ed113cd
to
4a6ce54
Compare
.github/pull_request_template.md
Outdated
- **HAND SIGNED** Company CLA must be on file (once per release): [Company CLA](https://github.com/nasa/cFE/blob/master/docs/GSC_18128_Corp_CLA_form_1219.pdf) | ||
- Else if Individual | ||
- **HAND SIGNED** Individual CLA must be on file (once per release): [Individual CLA](https://github.com/nasa/cFE/blob/master/docs/GSC_18128_Ind_CLA_form_1219.pdf) | ||
- Note CLA's apply to software contributions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no apostrophe '
, should add the word "only" before software contributions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@astrogeco - note that when I tried using the link to the subsection in the cFS contributing guide it didn't go to the appropriate section. Probably want to confirm this actually works...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It won't work until nasa/cFS#448 is merged. It does work on the fork https://github.com/chillfig/cFS/blob/add_cla/CONTRIBUTING.md#contributor-license-agreement-cla
Replaces explicit link to CLA files with link to CLA section in cFS/Contributing.md Adds checklist for CLA and contributing guide, removes extra spacing, changes grammar
4a6ce54
to
c36dd93
Compare
nasa/PSP#334, Fix input to static analysis workflow
nasa/PSP#334, Fix input to static analysis workflow
**Combines** nasa/cFE#2091 v7.0.0-rc4+dev110 **Includes** *cFE* nasa/cFE#2077, Remove contributor license agreement nasa/cFE#2085, Use reusable documentation generation workflow nasa/cFE#2080, Add config module to coverage enforcemnt nasa/cFE#2081, Improve ES unit test coverage nasa/cFE#2082, Only increment SB InternalErrorCounter on errors *osal* nasa/osal#1246, Apply latest contributor license agreement links *PSP* nasa/PSP#331, Apply latest contributor license agreement links nasa/PSP#334, Fix input to static analysis workflow Co-authored-by: Jacob Hageman <skliper@users.noreply.github.com> Co-authored-by: Justing Figueroa <chillfigskliper@users.noreply.github.com>
**Combines** nasa/cFE#2091 v7.0.0-rc4+dev110 **Includes** *cFE* nasa/cFE#2077, Remove contributor license agreement nasa/cFE#2085, Use reusable documentation generation workflow nasa/cFE#2080, Add config module to coverage enforcemnt nasa/cFE#2081, Improve ES unit test coverage nasa/cFE#2082, Only increment SB InternalErrorCounter on errors *osal* nasa/osal#1246, Apply latest contributor license agreement links *PSP* nasa/PSP#331, Apply latest contributor license agreement links nasa/PSP#334, Fix input to static analysis workflow Co-authored-by: Jacob Hageman <skliper@users.noreply.github.com> Co-authored-by: Justing Figueroa <chillfig@users.noreply.github.com>
Describe the contribution
Adds checklist for CLA and contributing guide.
Expected behavior changes
Working links
Additional context
Depends on nasa/cFS#448
Contributor Info - All information REQUIRED for consideration of pull request
Justin Figueroa, ASRC Federal